genji1024/koto
Watch
1
0
Fork
You've already forked koto
 0
Code Issues 1 Pull requests 1 Projects Releases Packages Wiki Activity Actions

ci(pr): check every pull request #2

Merged
genji1024 merged 1 commit from feat/ci into main 2026-10-07 19:54:43 +09:00
Conversation 0 Commits 1 Files changed 3 +51
genji1024 commented 2026-10-07 19:44:42 +09:00
Owner
Copy link

Summary

Adds CI for every pull request, so a broken change is caught before it reaches main and, with it, the demo.

Changes

  • .forgejo/workflows/ci.yml: on every pull request (or on demand), installs the web app's dependencies, then runs typecheck, lint, the unit tests and the production build, and checks the shell scripts' syntax.
  • Jobs run in a throwaway container (runner label docker), never directly on the host, and get no access to the Docker socket.
  • The integration suites skip themselves, since they need a homeserver.
  • Docs: docs/demo.md adds the container label to the runner, and docs/development.md lists what CI covers.

Notes

  • Lint currently reports 4 warnings and no errors. Warnings do not fail CI yet; once they are fixed, --deny-warnings can be turned on.
  • With the runner's capacity at 1, CI and the demo deploy run one at a time.

Follow-up

  • Protect main so that pull requests can only merge once this check passes.
## Summary Adds CI for every pull request, so a broken change is caught before it reaches `main` and, with it, the demo. ## Changes - **`.forgejo/workflows/ci.yml`**: on every pull request (or on demand), installs the web app's dependencies, then runs typecheck, lint, the unit tests and the production build, and checks the shell scripts' syntax. - Jobs run in a throwaway container (runner label `docker`), never directly on the host, and get no access to the Docker socket. - The integration suites skip themselves, since they need a homeserver. - **Docs**: `docs/demo.md` adds the container label to the runner, and `docs/development.md` lists what CI covers. ## Notes - Lint currently reports 4 warnings and no errors. Warnings do not fail CI yet; once they are fixed, `--deny-warnings` can be turned on. - With the runner's capacity at 1, CI and the demo deploy run one at a time. ## Follow-up - Protect `main` so that pull requests can only merge once this check passes.
ci(pr): check every pull request
All checks were successful
ci / check (pull_request) Successful in 1m59s
Details
ec5872fa04 
- Catch broken changes before they reach main and the demo
  - typecheck, lint, unit-test and build the web app
  - check the shell scripts' syntax
  - run in a throwaway container, never on the host
- Document how CI runs
  - add the container label to the demo runner
  - list what CI covers in the development guide
genji1024 deleted branch feat/ci 2026-10-07 19:54:43 +09:00
genji1024 referenced this pull request from a commit 2026-10-07 19:54:45 +09:00
merge: check every pull request
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
genji1024
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
genji1024/koto!2
No description provided.